[Solved] "dcl-Form-Show" returns "too many arguments"

EDIT: Solved - see below.
------------------

I have a modal dialogue to insert blocks, displayed in "images". There is a loop to

- open the dialogue initially
- close and open it when double-clicking the images
- close it when the button "close" (or Esc ..) are pressed.

As reported in the "Subject" of this posting. "dcl-Form-Show" returns "too many arguments" ...??

This is my structure:


; start of main-function
(defun c:MyApp (/ cmdecho form-type first-run value)

--> do some readings and preparartions and settings ...

    ;; Load the project
    (dcl-Project-Load "MyApp.odcl")

    ;; Show the main form
    (setq dialogstatus 20) ; the doubleclick on the images set this value on 20 to keep the loop alive until "Close"

    (while (= dialogstatus 20)

        (setq dialogstatus (dcl-Form-Show MyApp/MyApp))      ; here the modal dialogue will be shown. dialogstatus will be set via the close-commands

; a) here "oninitialize" will work
; b) then the doubleclick-events will work

        (if (= dialogstatus 20) ; if I click an image, 20 will be used and the loop continues
            (progn
                --> do something
            )
        )
    ) ; ende while
    (princ)
)
; end of main-function


; oninitialize
(defun c:MyApp/MyApp#OnInitialize (/)
--> do some communication between existing values and the display of controls, start the display of the images (load picture)
    (princ "\nInitialize fertig.")
)

; one doubleclick-event on "image"
(defun c:MyApp/MyApp/SigTaf_WMF1#OnDblClicked ()
--> do something, then close the dialogue with the value 20 to keep the loop alive
    (dcl-Form-Close MyApp/MyApp 20)
)

--> The CLOSE here returns 20 to the previous SHOW from above; then it does something and the loop keeps on.

; the standard close button
(defun c:MyApp/MyApp/Exit#OnClicked (/)
(dcl-Form-Close MyApp/MyApp 10)
)
--> this returns 10 to the SHOW from above, the loop will end.

The message "too many arguments" appears both when the dialogue starts the first time or when it is re-started from the loop.

What's wrong? The basic structure of the routine?

Thanks and regards

Hello Peter!
I not realy understand why should use variable dialogstatus.
Do you have problems to start form-dialog ?
If I run your code it works for me, but do you have some misstakes in named of dialog ?

here is my example with recall values after ->..., may it helps
(progn
  (command "_OPENDCL")
  (setq form (dcl-project-load "Form1.odcl")) ; -> "Form1"
  (setq returnResult (dcl-Form-Show Form1/Dialog_Option)) ; -> 1
  )

author=cadplayer link=topic=2405.msg12002#msg12002 date=1470763273 wrote:
...I not realy understand why should use variable dialogstatus....

Because there are different situations when closing the dialogue, and a different status can start different reactions.

Why do you think the problem is with dcl_Form-Show and not with c:MyApp/MyApp#OnInitialize?

author=roy_043 link=topic=2405.msg12007#msg12007 date=1470774428 wrote:
Why do you think the problem is with dcl_Form-Show and not with c:MyApp/MyApp#OnInitialize?

I wrote messages with "princ" to the code, and the appearance of the "too many arguments - message" showed me where it comes from.

But just now I also deactivated the "oninitialize-event" and the "oninitialize-code", and the message still appears.

To be clear: The message appears in the command-line, not in a dialogue.

Your problem is not caused by the dcl_Form-Show function. If that were the case the dialog would not display. IMO one of the ODCL event handlers must therefore be to blame. Try disabling all events and then switching them back on one by one.

author=roy_043 link=topic=2405.msg12014#msg12014 date=1470818943 wrote:
Your problem is not caused by the dcl_Form-Show function. If that were the case the dialog would not display. IMO one of the ODCL event handlers must therefore be to blame. ...

Yes - you are right.

Thanks to the detailed error reports in Bricscad I found the problem. BricsCAD told me:

Initialize fertig.
; ----- LISP : Call Stack -----
; ...C:MyApp
; .....DCL-FORM-SHOW <<--
;
; ----- Error around expression -----
(AL_EXECUTEADSDEFUN "DCL-FORM-CLOSE" REST)
;
; error : too few / too many arguments at
;
; error : during LISP function [c:MyApp/MyApp#OnClose] invoke from BRX/SDS interface,
          please check Lisp function definition and call arguments.

The reason behind was that I used the wrong code in "OnClose"
(defun c:MyApp/MyApp#OnClose ( /)
the right code is
(defun c:MyApp/MyApp#OnClose (intUpperLeftX intUpperLeftY /)
Thanks for help.